Our new schedule of meeting every other week seems to be working well. Today we had a decent but not overwhelming number of bugs and managed to wrap up in well under an hour.
WiX v3.10.3 update
This week's update on WiX v3.10.3 is pretty minimal: We're still waiting for details from the GDI+ team that we could use to provide a workaround to their bug. Rob's assuming that slow responses are due to lots of people preparing for next week's Build conference.
Issue triage
FileVersionFromStringEx doesn't understand vVersion #5236 comes from me after I discovered that Burn doesn't correctly handle comparisons between a version variable and a string variable in
vMajor.Minorsyntax. We took the bug into WiX v4 and v3.11 and I gave it to myself, as punishment for finding a bug.Documentation - Update Element says it is not an implemented feature #5237, from @NickMRamirez, points out some obsolete doc.
New bootstrapper fails to run when performing an UpdateReplace #5238 is from @squirmy, who appeared to run into a long-standing race condition when using bundle updates. Luckily, @rseanhall was on the case and provided the pull request we reviewed in today's meeting. We took the issue into WiX v3.11 and debated whether to also take it into WiX v3.10.3. The issue wasn't entirely resolved (meaning I was in the minority but decided not to throw a tantrum) and will be up to Rob when we cut v3.10.3.
Compiler does not pass context values to ComponentGroup child element extension point. #5239 is a request from @tg73 to supply more context when a compiler extension parses a custom element under the
ComponentGroupelement. As it's backward compatible, we took the request into WiX v3.x.DTF: Isolated storage doesn't work #5240 from frequent contributor @rseanhall shows that a DTF custom action cannot use isolated storage. Assuming that making it work would be backward compatible, we took the issue into WiX v3.x.
OnExecutePackageComplete called without corresponding OnExecutePackageBegin #5241 is a report from @heaths about mismatched
Begin/Completecallbacks to a bootstrapper application if an error occurs.Begin/Completecallbacks should also come as pairs, never one without the other. Because the fix changes behavior, we took this in WiX v4.MSP not removed when patch-related bundle is uninstalled #5242, also from @heaths, states that Burn doesn't uninstall a patch when its parent patch bundle is uninstalled. That's not great behavior so we took this bug in WiX v4.
WiX Finish Dialog appears partially off screen, if install Progress Dialog is minimized. #5243 from @tushardevsharma if more of a question that should go to wix-users. In any case, for this particular issue, WiX is not guilty of all charges.
Pull request review
This week's pull request is @rseanhall's fix for New bootstrapper fails to run when performing an UpdateReplace #5238. There was some confusion, mostly on Rob's and my part—Sean understood it fine—about the underlying bug but in the end we decided it was a simple fix to help avoid the race condition described in the bug.